Re: [PATCH] gpu: nova: fix rust-analyzer generation
From: Timur Tabi
Date: Wed Jul 01 2026 - 14:40:01 EST
On Wed, 2026-07-01 at 15:40 +0900, Alexandre Courbot wrote:
> The rust-analyzer generator script recognizes a crate when its
> corresponding `.o` appears in the Rust source file's immediate `Makefile`
> or `Kbuild` file.
>
> Commit ca524e273c43 ("gpu: build nova-core and nova-drm from
> drivers/gpu/Makefile") moves the build rules for `nova-core` and
> `nova-drm` into `drivers/gpu/Makefile`, which results in the generator
> script ignoring these crates.
>
> Fix this by naming the crates' module as a comment in their respective
> `Makefile`; this is enough for the script to pick them up and restore
> `rust-analyzer` functionality on them.
>
> Fixes: ca524e273c43 ("gpu: build nova-core and nova-drm from drivers/gpu/Makefile")
> Signed-off-by: Alexandre Courbot <acourbot@xxxxxxxxxx>
Tested-by: Timur Tabi <ttabi@xxxxxxxxxx>
Thanks for fixing this bug so quickly. It was driving me crazy.