Re: [PATCH 1/3] ASoC: codecs: tas675x: use READ_ONCE for params to be used concurrently
From: Mark Brown
Date: Wed Jul 01 2026 - 14:55:55 EST
On Tue, Jun 30, 2026 at 01:31:20PM -0500, Sen Wang wrote:
> active_playback_dais and active_capture_dais are written atomically via
> set_bit()/clear_bit() and can be read concurrently from the
> fault_check_work delayed work handler.
>
> fault_check_work already uses READ_ONCE; extend the same guard to all other
> reads in tas675x_hw_params() and tas675x_mute_stream().
I'm not convinced that any of this READ_ONCE stuff is safe, that's a
very unusual pattern for an I2C device like these, but given that I
missed it earlier I'll take the patch for now.
Attachment:
signature.asc
Description: PGP signature