Re: [PATCH] mm/migrate_device: pin large folios before splitting

From: David Hildenbrand (Arm)

Date: Wed Jul 01 2026 - 16:19:52 EST


On 7/1/26 21:27, Andrew Morton wrote:
> On Wed, 01 Jul 2026 13:02:10 -0400 Zi Yan <ziy@xxxxxxxxxx> wrote:
>
>> LGTM. Like David said, the comments might not be needed. Thanks.
>
> I like the comments! They may be uninteresting to those who are
> already familiar with these things, but they aren't the target audience.
>
> How are others to become familiar, if not by this?

I mean, it's one of the basic rules: if you lookup a page in the page table, the
moment you drop the lock that might be invalid.

If we were to document that everywhere... this is not really the secret sauce we
want to document everywhere.

--
Cheers,

David