Re: [PATCH RESEND v5 1/3] x86/asm, x86/boot: expose inline memcmp

From: Borislav Petkov

Date: Wed Jul 01 2026 - 16:47:12 EST


On Wed, Jul 01, 2026 at 04:57:57PM -0300, Mauricio Faria de Oliveira wrote:
> I'm not sure, as Reported-by and Suggested-by mean something different.
>
> Maybe a simpler statement would do? e.g., '(Thanks to David Laight for
> noticing the return value difference between inline and regular
> memcmp())'. That gives credit while avoiding confusion with tags.

The Link tag already points to the review thread where we document who
suggested what. We don't document who gave what review comments and
suggestions for the simple reason that that would be intractable and the other
simple reason is that they don't belong in the commit message.

Changelog comments belong *exactly* under the "---" line.

--
Regards/Gruss,
Boris.

https://people.kernel.org/tglx/notes-about-netiquette