Re: [PATCH v11 3/5] iio: adc: versal-sysmon: add I2C driver
From: Jonathan Cameron
Date: Wed Jul 01 2026 - 20:08:31 EST
On Tue, 23 Jun 2026 12:33:33 +0100
"Erim, Salih" <salih.erim@xxxxxxx> wrote:
> Addressing Sashiko findings on this patch:
>
> - [High] Non-atomic I2C read transaction releases the bus lock,
> making it vulnerable to bus interleaving.
>
> The SysMon I2C interface is typically on a dedicated bus with
> no other devices. The current implementation works correctly
> in all tested configurations. Switching to i2c_transfer() with
> Repeated Start would match the TRM protocol diagram but would
> require hardware testing on a board with I2C-accessible SysMon.
> No change for now.
>
To me this smells like a nice to have. However, I agree with your
comment that it almost certainly doesn't matter. Maybe one to add
to the backlog for next time any new features are being added to the driver.