Re: [PATCH] ALSA: pcm: Drop reduntant nonseekable_open() return check

[Takashi Iwai]

On Thu, 02 Jul 2026 05:57:04 +0200,
phucduc.bui@xxxxxxxxx wrote:
> 
> From: bui duc phuc <phucduc.bui@xxxxxxxxx>
> 
> nonseekable_open() always returns 0, so the error check is unnecessary.
> Remove the dead error handling path.
> 
> Signed-off-by: bui duc phuc <phucduc.bui@xxxxxxxxx>
> ---
>  sound/core/pcm_native.c | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
> 
> diff --git a/sound/core/pcm_native.c b/sound/core/pcm_native.c
> index 7dc0060617f1..b245b596d95a 100644
> --- a/sound/core/pcm_native.c
> +++ b/sound/core/pcm_native.c
> @@ -2874,8 +2874,7 @@ static int snd_pcm_playback_open(struct inode *inode, struct file *file)
>  {
>  	struct snd_pcm *pcm;
>  	int err = nonseekable_open(inode, file);
> -	if (err < 0)
> -		return err;
> +

We don't have to assign err here, right?
Keeping it looks rather confusing.

>  	pcm = snd_lookup_minor_data(iminor(inode),
>  				    SNDRV_DEVICE_TYPE_PCM_PLAYBACK);
>  	err = snd_pcm_open(file, pcm, SNDRV_PCM_STREAM_PLAYBACK);
> @@ -2888,8 +2887,7 @@ static int snd_pcm_capture_open(struct inode *inode, struct file *file)
>  {
>  	struct snd_pcm *pcm;
>  	int err = nonseekable_open(inode, file);
> -	if (err < 0)
> -		return err;
> +

Ditto.

I see a similar pattern in your other patches.  Please try to address
it and resubmit -- at best, as a v2 series of patches.


thanks,

Takashi