Re: [PATCH 1/2] dt-bindings: arm: omap: Convert DSP to DT schema

[Krzysztof Kozlowski]

On Tue, Jun 30, 2026 at 01:28:55PM +0000, Eduard Bostina wrote:
> Convert the Texas Instruments DSP bindings to DT schema.
> 
> During the conversion, ti,hwmods has been made optional.

You need to explain why.

> 
> Signed-off-by: Eduard Bostina <egbostina@xxxxxxxxx>
> ---
>  .../devicetree/bindings/arm/omap/dsp.txt      | 14 --------
>  .../bindings/arm/omap/ti,omap3-c64.yaml       | 32 +++++++++++++++++++

This should be moved to bindings/soc/ti/ directory


>  2 files changed, 32 insertions(+), 14 deletions(-)
>  delete mode 100644 Documentation/devicetree/bindings/arm/omap/dsp.txt
>  create mode 100644 Documentation/devicetree/bindings/arm/omap/ti,omap3-c64.yaml
> 
> diff --git a/Documentation/devicetree/bindings/arm/omap/dsp.txt b/Documentation/devicetree/bindings/arm/omap/dsp.txt
> deleted file mode 100644
> index d3830a32ce08..000000000000
> --- a/Documentation/devicetree/bindings/arm/omap/dsp.txt
> +++ /dev/null
> @@ -1,14 +0,0 @@
> -* TI - DSP (Digital Signal Processor)
> -
> -TI DSP included in OMAP SoC
> -
> -Required properties:
> -- compatible : Should be "ti,omap3-c64" for OMAP3 & 4
> -- ti,hwmods: "dsp"
> -
> -Examples:
> -
> -dsp {
> -    compatible = "ti,omap3-c64";
> -    ti,hwmods = "dsp";
> -};
> diff --git a/Documentation/devicetree/bindings/arm/omap/ti,omap3-c64.yaml b/Documentation/devicetree/bindings/arm/omap/ti,omap3-c64.yaml
> new file mode 100644
> index 000000000000..72429749ebf4
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/arm/omap/ti,omap3-c64.yaml
> @@ -0,0 +1,32 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/arm/omap/ti,omap3-c64.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Texas Instruments DSP (Digital Signal Processor)
> +
> +maintainers:
> +  - Eduard Bostina <egbostina@xxxxxxxxx>
> +
> +properties:
> +  compatible:
> +    const: ti,omap3-c64
> +
> +  ti,hwmods:
> +    description: Name of the hwmod associated to the dsp
> +    $ref: /schemas/types.yaml#/definitions/string-array

Same comments as before. The type is already fixed to string. Why this
has to be an array? Do Linux drivers read it as an array?

> +    items:
> +      - const: dsp

Best regards,
Krzysztof