Re: [PATCH 2/8] dt-bindings: mfd: ROHM BD73800 PMIC

[Matti Vaittinen]

Hi dee Ho Krzysztof!

Thanks for the review (again)!

On 02/07/2026 11:05, Krzysztof Kozlowski wrote:
> On Wed, Jul 01, 2026 at 03:41:34PM +0300, Matti Vaittinen wrote:
> > +description:
> > +  BD73800GW is a single-chip power management IC for battery-powered
> > +  portable devices. It integrates 8 buck converters, 4 LDOs and a current
> > +  sense amplifier with ADC. Also included is a Real Time Clock (RTC) and a
> > +  32.768 kHz clock gate. Depending on the OTP configuration the BD73800
> > +  may also have interrupt controller and GPIOs.
> > +
> > +  There are also different variants called BD71851 and BD71885 which are
> > +  almost identical from the software point of view.
> > +
> > +properties:
> > +  compatible:
> > +    oneOf:
> > +      - const: rohm,bd73800
> > +
> > +      - items:
> > +          - const: rohm,bd71851
> > +          - const: rohm,bd73800
> > +
> > +      - items:
> > +          - const: rohm,bd71885
>
> items:
>    - enum:
>        -
>        -
>    - const: rohm,bd73800

I suppose this will mean compatible is one of the enum values AND 
rohm,bd73800 as a fallback, while accepting also the rohm,bd73800 alone. 
(No need to reply, I will test it out). If so, then I'll do this for the 
next version (which is probably out only at August).

> > +          - const: rohm,bd73800
> > +
> > +  reg:
> > +    maxItems: 1
> > +
> > +  interrupts:
> > +    maxItems: 1
> > +
> > +  # The GPIO1, CLKOUT (GPIO2), FAULT_B and EXTEN_OUT pins can be
> > +  # configured to interrupt pins by OTP.
> > +  interrupt-controller: true
> > +
> > +  "#interrupt-cells":
> > +    const: 1
> > +    description:
> > +      The IRQ number. 0 is GPIO1, 1 CLKOUT (GPIO2), 2 FAULT_B and 3 EXTEN_OUT.
> > +      NOTE, A pin can operate as IRQ source only when the OTP
> > +      configuration for it has been set to GPI.
> > +
> > +  gpio-controller: true
> > +
> > +  "#gpio-cells":
> > +    const: 2
> > +
> > +# The GPIO1, CLKOUT, FAULT_B and EXTEN_OUT pins may be configured for a
>
> Missing two spaces (indent) before the comment, although this should be
> put into description. I understand it applies to each description - it
> is fine to add to the first one. Descriptions might be used to generate
> user-friendly representation of bindings (PDF). Comments won't, so
> comments are only to explain the binding/schema syntax choices.

This comment sounds like someone is crafting a tool which can convert 
the bindings to human-readable spec? For someone as yaml-illiterate as 
me, this really brings some hope :) Although, I would hope we saw some 
"comment-key" which could be used to mark the comment to be included in 
said human-readable format. Stuffing it in the 1.st description is Ok, 
but still somewhat sub-optimal. Oh well, "Ok" will do - I'll add this to 
the description when re-spinning.

I do appreciate your help and feedback (as always!).

Yours,
	-- Matti

--
Matti Vaittinen
Linux kernel developer at ROHM Semiconductors
Oulu Finland

~~ When things go utterly wrong vim users can always type :help! ~~