Re: [PATCH v2 0/7] ALSA: Remove redundant open helper return checks

[Cezary Rojewski]

On 7/2/2026 10:44 AM, phucduc.bui@xxxxxxxxx wrote:
> From: bui duc phuc <phucduc.bui@xxxxxxxxx>
>
> Hi all,
>
> This series removes redundant error checks after calls to
> nonseekable_open() and stream_open() in the ALSA core.
>
> nonseekable_open() always returns 0, so checking its return value is
> unnecessary.
>
> Several users were later converted from nonseekable_open() to
> stream_open(), but the original error checks were retained.
> Since stream_open() also always returns 0, those checks are likewise
> unnecessary.
>
> As a result, all patches simply remove dead error handling paths with no
> functional change.
>
> Change in v2 :
>   - Drop the unnecessary assignment of the return value from
>     nonseekable_open()/stream_open(), as suggested by Takashi.
>   - Merge the individual patches into a single patch series.
Hi Phuc,

Now I released you've sent v2 within few hours of sending v1.  The 
comments I've provided for v1 are already addressed in v2 so:

Reviewed-by: Cezary Rojewski <cezary.rojewski@xxxxxxxxx>


Kinds regards,
Czarek