Re: [PATCH 2/2] dt-bindings: arm: omap: Convert IVA to DT schema
From: Eddie
Date: Thu Jul 02 2026 - 11:57:50 EST
On Thu, Jul 2, at 18:03, Krzysztof Kozlowski <krzk@xxxxxxxxxx> wrote:
> > I will add the justification to the commit message in v2: the TI hwmod
> > framework is legacy and is being phased out, so new device tree nodes
> > should not be required to include it.
>
> This should not be part of the conversion but separate commit with
> separate reason and analysis of actual ABI usage. During conversion you
> only make changes necessary to finish it, not things you in general find
> better.
Understood. The reason I included it in the conversion was that
keeping hwmods required causes dtbs_check warnings as several dts
files omit it.
However, I completely understand the need to separate it.
For v2, I will structure this as a two patch series per component:
1. A 1:1 conversion keeping ti,hwmods required.
2. A separate patch dropping the requirement, including the ABI
analysis in the commit message.
Quick question regarding the general rule of thumb for these
conversions. I understand the expected pattern is Patch 1 (strict 1:1
conversion) followed by patches fixing the dtbs_check warnings (adding
undocumented properties that are used or dropping requirements). For
those follow-up fixes, do you prefer one commit per property changed,
or is it ok to group all the warning fixes for a specific file into a
single follow-up commit?
Thanks for the guidance.