Re: [PATCH v2 01/11] arm: Use sysfs_emit() for cpumask show callbacks

From: Greg Kroah-Hartman

Date: Thu Jul 02 2026 - 11:58:59 EST


On Thu, Jul 02, 2026 at 11:47:14AM -0400, Yury Norov wrote:
> These callbacks are sysfs show paths.
>
> Use sysfs_emit() and cpumask_pr_args() to emit the masks.
>
> This prepares for removing cpumap_print_to_pagebuf().
>
> Signed-off-by: Yury Norov <ynorov@xxxxxxxxxx>
> ---
> arch/arm/mach-imx/mmdc.c | 2 +-
> arch/arm/mm/cache-l2x0-pmu.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/mach-imx/mmdc.c b/arch/arm/mach-imx/mmdc.c
> index b71467c48b87..f6d993b9b1d4 100644
> --- a/arch/arm/mach-imx/mmdc.c
> +++ b/arch/arm/mach-imx/mmdc.c
> @@ -127,7 +127,7 @@ static ssize_t mmdc_pmu_cpumask_show(struct device *dev,
> {
> struct mmdc_pmu *pmu_mmdc = dev_get_drvdata(dev);
>
> - return cpumap_print_to_pagebuf(true, buf, &pmu_mmdc->cpu);
> + return sysfs_emit(buf, "%*pbl\n", cpumask_pr_args(&pmu_mmdc->cpu));

Really? Looks like the original is much simpler to understand, why must
this function go away?

thanks,

greg k-h