Re: [PATCH v3 2/2] iio: adc: ad7779: Remove redundant dev_err_probe() after devm_request_irq()

[Jonathan Cameron]

On Thu, 2 Jul 2026 13:54:54 +0200
Joshua Crofts <joshua.crofts1@xxxxxxxxx> wrote:

> On Thu,  2 Jul 2026 11:46:49 +0000
> Moksh Panicker <mokshpanicker.7@xxxxxxxxx> wrote:
> 
> > devm_request_irq() already prints an error message on failure via the
> > IRQ core, so wrapping its return value in dev_err_probe() results in a
> > duplicate error message. Return the error directly instead.
> > 
> > Suggested-by: Joshua Crofts <joshua.crofts1@xxxxxxxxx>
> > Signed-off-by: Moksh Panicker <mokshpanicker.7@xxxxxxxxx>
> > ---
> >  drivers/iio/adc/ad7779.c | 3 +--
> >  1 file changed, 1 insertion(+), 2 deletions(-)
> > 
> > diff --git a/drivers/iio/adc/ad7779.c b/drivers/iio/adc/ad7779.c
> > index c1a99b4c1256..a5b8bfa99a74 100644
> > --- a/drivers/iio/adc/ad7779.c
> > +++ b/drivers/iio/adc/ad7779.c
> > @@ -842,8 +842,7 @@ static int ad7779_setup_without_backend(struct ad7779_state *st, struct iio_dev
> >  			       IRQF_NO_THREAD | IRQF_NO_AUTOEN, indio_dev->name,
> >  			       st->trig);
> >  	if (ret)
> > -		return dev_err_probe(dev, ret, "request IRQ %d failed\n",
> > -				     st->spi->irq);
> > +		return ret;
> >  
> >  	ret = devm_iio_trigger_register(dev, st->trig);
> >  	if (ret)  
> 
> Reviewed-by: Joshua Crofts <joshua.crofts1@xxxxxxxxx>
> 
Applied.