Re: [PATCH rdma-next 1/1] RDMA/mana_ib: Adopt robust udata

[Jason Gunthorpe]

On Tue, Jun 23, 2026 at 04:44:43AM -0700, Konstantin Taranov wrote:

> +struct mana_ib_uctx_req {
> +	__aligned_u64 client_caps1;
> +	__aligned_u64 client_caps2;
> +	__aligned_u64 client_caps3;
> +	__aligned_u64 client_caps4;
> +	__aligned_u64 comp_mask;
> +};

I think Jacob has it right, This is looking pretty gross.

If you want such a complex protocol then use the new ioctl format and
declare sensible driver specific attributes. Nobody has converted
alloc_ucontext yet, but that is usually not hard to do.

Then you can use the existing mandatory/optional schemes to pass
whatever is appropriate with full easy compat.

So maybe split this part out, the rst of the udata fiddling looks OK

Jason