Re: [PATCH] platform/x86: thinkpad_acpi: update stale thinkwiki.org URLs

[Mark Pearson]

Thanks Anas

On Thu, Jul 2, 2026, at 6:13 AM, Anas Khan wrote:
> The three thinkwiki.org references in thinkpad_acpi.c redirect to the
> canonical www.thinkwiki.org host. Update them to the current URLs.
>
> Signed-off-by: Anas Khan <anxkhn28@xxxxxxxxx>
> ---
>  drivers/platform/x86/lenovo/thinkpad_acpi.c | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/platform/x86/lenovo/thinkpad_acpi.c 
> b/drivers/platform/x86/lenovo/thinkpad_acpi.c
> index 445e1403308e..c57f46cfbcbe 100644
> --- a/drivers/platform/x86/lenovo/thinkpad_acpi.c
> +++ b/drivers/platform/x86/lenovo/thinkpad_acpi.c
> @@ -7826,7 +7826,7 @@ static struct ibm_struct volume_driver_data = {
>   *	does so, its initial value is meaningless (0x07).
>   *
>   *	For firmware bugs, refer to:
> - 
> *	https://thinkwiki.org/wiki/Embedded_Controller_Firmware#Firmware_Issues
> + 
> *	https://www.thinkwiki.org/wiki/Embedded_Controller_Firmware#Firmware_Issues
>   *
>   * 	----
>   *
> @@ -7851,7 +7851,7 @@ static struct ibm_struct volume_driver_data = {
>   *	mode.
>   *
>   *	For firmware bugs, refer to:
> - 
> *	https://thinkwiki.org/wiki/Embedded_Controller_Firmware#Firmware_Issues
> + 
> *	https://www.thinkwiki.org/wiki/Embedded_Controller_Firmware#Firmware_Issues
>   *
>   *	----
>   *
> @@ -11754,7 +11754,7 @@ static int __must_check __init 
> get_thinkpad_model_data(
>  	 * X32 or newer, all Z series;  Some models must have an
>  	 * up-to-date BIOS or they will not be detected.
>  	 *
> -	 * See https://thinkwiki.org/wiki/List_of_DMI_IDs
> +	 * See https://www.thinkwiki.org/wiki/List_of_DMI_IDs
>  	 */
>  	while ((dev = dmi_find_device(DMI_DEV_TYPE_OEM_STRING, NULL, dev))) {
>  		if (sscanf(dev->name,
> @@ -12289,8 +12289,8 @@ MODULE_DEVICE_TABLE(acpi, ibm_htk_device_ids);
>  /*
>   * DMI matching for module autoloading
>   *
> - * See https://thinkwiki.org/wiki/List_of_DMI_IDs
> - * See https://thinkwiki.org/wiki/BIOS_Upgrade_Downloads
> + * See https://www.thinkwiki.org/wiki/List_of_DMI_IDs
> + * See https://www.thinkwiki.org/wiki/BIOS_Upgrade_Downloads
>   *
>   * Only models listed in thinkwiki will be supported, so add yours
>   * if it is not there yet.
> -- 
> 2.54.0

I would rather remove these links completely. 
It's basically advertising for a non-Lenovo site that is not up to date with the latest information (the list of DMI IDs is ancient).

FWIW: 
 - FW issues should be posted on forums.lenovo.com/linux which we monitor
 - The DMI IDs should be retrieved from psref.lenovo.com
 - FW updates come from LVFS and not tracked on an out of date website :)

Afraid I'm going to nack this one.

Mark