Re: [PATCH 2/5] iio: adc: ti-adc084s021: use dev_err_probe for probe time error

[Jonathan Cameron]

On Fri, 19 Jun 2026 09:49:19 -0500
David Lechner <dlechner@xxxxxxxxxxxx> wrote:

> On 6/18/26 6:14 PM, Prashant Rahul wrote:
> > This simplifies error handling and ensures consistent error reporting.
> > 
> > Signed-off-by: Prashant Rahul <prashantrahul23@xxxxxxxxx>
> > ---
> >  drivers/iio/adc/ti-adc084s021.c | 3 +--
> >  1 file changed, 1 insertion(+), 2 deletions(-)
> > 
> > diff --git a/drivers/iio/adc/ti-adc084s021.c b/drivers/iio/adc/ti-adc084s021.c
> > index a100f770fa1c..9c7ee09955ca 100644
> > --- a/drivers/iio/adc/ti-adc084s021.c
> > +++ b/drivers/iio/adc/ti-adc084s021.c
> > @@ -230,8 +230,7 @@ static int adc084s021_probe(struct spi_device *spi)
> >  					    adc084s021_buffer_trigger_handler,
> >  					    &adc084s021_buffer_setup_ops);
> >  	if (ret) {
> > -		dev_err(&spi->dev, "Failed to setup triggered buffer\n");
> > -		return ret;
> > +		return dev_err_probe(&spi->dev, ret, "Failed to setup triggered buffer\n");
> >  	}  
> 
> 
> Can drop the braces here
> 
Dropped whilst applying.  I'm a bit in two minds on whether we should print
anything on this one given the incredibly low chance of anyone having
a bug that double registers the buffer - still better as dev_err_probe()
then dev_err() so applied.
> >  
> >  	return devm_iio_device_register(&spi->dev, indio_dev);  
>