Re: [PATCH v3 1/8] irqchip/qcom-pdc: restructure version support

From: Maulik Shah (mkshah)

Date: Fri Jul 03 2026 - 04:38:25 EST




On 6/30/2026 8:08 PM, Thomas Gleixner wrote:
> On Tue, Jun 16 2026 at 14:55, Maulik Shah wrote:
>> @@ -336,7 +418,8 @@ static int pdc_setup_pin_mapping(struct device_node *np)
>> return -EINVAL;
>>
>> pdc_region_cnt = n / 3;
>> - pdc_region = kzalloc_objs(*pdc_region, pdc_region_cnt);
>> + pdc_region = devm_kcalloc(dev, pdc_region_cnt, sizeof(*pdc_region),
>> + GFP_KERNEL);
>
> No line break required. You have 100 characters
>
> Other than that nit, this looks sane now.

Sure. I will update in v4.

Thanks,
Maulik