Re: [PATCH 5/5] gpio: nomadik: drop "chip registered" log on probe success

[Bartosz Golaszewski]

On Thu, 2 Jul 2026 10:34:02 +0200, "Théo Lebrun" <theo.lebrun@xxxxxxxxxxx> said:
> Hello Linus,
>
> On Thu Jul 2, 2026 at 10:00 AM CEST, Linus Walleij wrote:
>> On Wed, Jul 1, 2026 at 6:57 PM Théo Lebrun <theo.lebrun@xxxxxxxxxxx> wrote:
>>
>>> Successful driver probing should be silent. Drop unconditional
>>> dev_info() call that is done at nmk_gpio_probe() exit.
>>>
>>> Signed-off-by: Théo Lebrun <theo.lebrun@xxxxxxxxxxx>
>>
>> I actually don't generally agree, but you are using this driver more than
>> me now so let's go with your minimalist dmesg style for this driver.
>
> I get from where you stand, but the info level is somewhat strong.
> Documentation/process/coding-style.rst agrees ("When drivers are
> working properly they are quiet").
>
> If you like this log line we can turn it into a lower debug level?
>
>> Reviewed-by: Linus Walleij <linusw@xxxxxxxxxx>
>
> Thanks for the reviews Linus!
>

My personal preference is for silent drivers too. You can find out if the
driver probed correctly from sysfs. Only if it didn't, do you need to know
why from the kernel log.

Bart