Re: [PATCH RFC 0/2] Correctly use TX macro v9.4 for SC7280 / Kodiak
From: Luca Weiss
Date: Fri Jul 03 2026 - 05:46:50 EST
Hi all,
On Tue May 26, 2026 at 5:29 PM CEST, Luca Weiss wrote:
> With the v9 data, that sc7280 is mistakenly using, the controls will
> have completely wrong names and using wrong code paths that do not apply
> to TX macro v9.4.
>
> This is an RFC to get some feedback how to continue.
>
> 1. We update the "qcom,sc7280-lpass-tx-macro" compatible to 9.4, break
> unchanged dtbs (the sources are updated in this series) and break UCM
> until it's updated.
>
> 2. We add a new compatible "qcom,sc7280-lpass-tx-macro-fixed" - name is
> just a suggestion ;) - and make sure existing boards with audio keep
> using the old "broken" compatible. This should be completely
> backwards compatible, since we keep the existing compatible working
> as-is.
>
> 3. We add some dt flag "qcom,use-correct-tx-macro-version;" and handle
> the rest similar to option 2, by opting in boards to the updated
> behavior.
>
> 4. We keep everything the same. We know it's wrong, both the
> audio-routing in dtb and the controls in UCM have incorrect names,
> but it's working apparently.
>
> Please let me know your thoughts.
Any feedback on this series? I'd appreciate it!
Regards
Luca
>
> As a bit of a note where I'm coming from, I'm working on microphone
> bringup for qcm6490-fairphone-fp5 where so far we've been using
> qcom,sm8450-lpass-tx-macro to get the correct control names. I've tried
> reverting to sc7280-lpass-tx-macro, updating audio-routing in dts and
> UCM to the v9.0 names and it does seem that microphone (AMIC1) is
> working with that, but I'm not particularly happy about leaving the
> wrong control names everywhere, so I'm happy to try and untangle this
> situation.
>
> I'm also not sure where this v9.x actually comes from, maybe I'm lacking
> some documentation, downstream kernel only refers to Bolero v1.x and
> v2.x so these seems to be a completely different versioning system.
>
> Signed-off-by: Luca Weiss <luca.weiss@xxxxxxxxxxxxx>
> ---
> Luca Weiss (2):
> ASoC: codecs: lpass-tx-macro: Use correct config for sc7280
> arm64: dts: qcom: kodiak: Fix up LPASS TX macro v9.4 control names
>
> arch/arm64/boot/dts/qcom/qcm6490-idp.dts | 2 +-
> .../boot/dts/qcom/qcs6490-radxa-dragon-q6a.dts | 2 +-
> arch/arm64/boot/dts/qcom/sc7280-crd-r3.dts | 22 +++++++++++-----------
> .../dts/qcom/sc7280-herobrine-audio-wcd9385.dtsi | 22 +++++++++++-----------
> .../dts/qcom/sc7280-herobrine-villager-r1.dtsi | 22 +++++++++++-----------
> arch/arm64/boot/dts/qcom/sc7280-idp.dtsi | 22 +++++++++++-----------
> sound/soc/codecs/lpass-tx-macro.c | 9 ++-------
> 7 files changed, 48 insertions(+), 53 deletions(-)
> ---
> base-commit: 550604d6c9b9efc8d068aff94dc301694a7afdee
> change-id: 20260526-sc7280-tx-macro-1179d786af1f
>
> Best regards,
> --
> Luca Weiss <luca.weiss@xxxxxxxxxxxxx>