RE: [PATCH net-next 04/17] net: dsa: mv88e6xxx: Add RMU enable/disable for select switches.

[Jagielski, Jedrzej]

From: Luke Howard <lukeh@xxxxxxxx> 
Sent: Friday, July 3, 2026 9:47 AM

>From: Mattias Forsblad <mattias.forsblad@xxxxxxxxx>
>
>Add RMU enable and disable functionality for some Marvell SOHO
>switches.
>
>Reviewed-by: Andrew Lunn <andrew@xxxxxxx>
>Reviewed-by: Florian Fainelli <f.fainelli@xxxxxxxxx>
>Signed-off-by: Mattias Forsblad <mattias.forsblad@xxxxxxxxx>
>Signed-off-by: Andrew Lunn <andrew@xxxxxxx>
>---

you tag should be the last one

>+int mv88e6085_g1_rmu_enable(struct mv88e6xxx_chip *chip, int port)
>+{
>+	int val = MV88E6352_G1_CTL2_RMU_MODE_DISABLED;

unclear for me why to init it if all allowed scenarios put some values into val?
here and for following


>+
>+	switch (port) {
>+	case 9:
>+		val = MV88E6085_G1_CTL2_RM_ENABLE;
>+		break;
>+	case 10:
>+		val = MV88E6085_G1_CTL2_RM_ENABLE | MV88E6085_G1_CTL2_P10RM;
>+		break;
>+	default:
>+		return -EOPNOTSUPP;
>+	}
>+
>+	return mv88e6xxx_g1_ctl2_mask(chip, MV88E6085_G1_CTL2_P10RM |
>+				      MV88E6085_G1_CTL2_RM_ENABLE, val);
>+}