Re: [PATCH v2 5/6] dt-bindings: dma: qcom,bam-dma: Increase iommus maxItems to seven

From: Krzysztof Kozlowski

Date: Sat Jul 04 2026 - 04:39:15 EST


On 04/07/2026 10:37, Krzysztof Kozlowski wrote:
> On 03/07/2026 11:01, Kuldeep Singh wrote:
>>
>>
>> On 03-07-2026 14:27, Konrad Dybcio wrote:
>>> On 7/3/26 10:38 AM, Kuldeep Singh wrote:
>>>> On 03-07-2026 12:24, Krzysztof Kozlowski wrote:
>>>>> On Thu, Jul 02, 2026 at 01:47:15AM +0530, Kuldeep Singh wrote:
>>>>>> Upcoming Shikra BAM DMA uses 7 IOMMU entries and not 6, so increase the
>>>>>> `iommus` maxItems constraint.
>>>>>>
>>>>>> Fix below error:
>>>>>> dma-controller@1b04000 (qcom,bam-v1.7.4): iommus: [[25, 132, 17], [25,
>>>>>
>>>>> There is no dma-controller@1b04000 in DTS. Please drop all the warnings
>>>>> which do not exist.
>>>>
>>>> Kindly check patch 6/6, it is introducing bam node with 7iommus which IP
>>>> describes and hence, updated bindings before to accustom this which also
>>>> helps in avoiding rob's dt-schema bot error.
>>>
>>> Krzysztof is saying that the error doesn't exist in the tree (because
>>> the offending DTS hunk is not merged), so you shouldn't claim this fixes
>>> an error, rather that Shikra simply needs it
>>
>> In previous patchset, krzysztof ask was to add error in commit log and
>> hence updated that.
>> Maybe some misunderstanding!
>
> From that answer you should have understood there are no warnings to be
> fixed, no warnings to be mentioned, so that commit msg should have been
> fixed.
>
> Solution is not to add fake warnings in such case, like you did here.
>


I even said that to you last time at v1!

"Again, there is no error. Revert this patch and check."

https://lore.kernel.org/all/c6415963-ef68-4422-a7fb-fd23b007de32@xxxxxxxxxx/

Best regards,
Krzysztof