Re: [PATCH v4 2/6] irqchip/gic-v3-its: Fix its node leak in gic_acpi_parse_madt_its()

[Radu Rendec]

On Thu, 2026-07-02 at 11:30 +0800, Kemeng Shi wrote:
> Fix its node leak when its_probe_one() failed in
> gic_acpi_parse_madt_its().
> 
> Fixes: 9585a495ac936 ("irqchip/gic-v3-its: Split allocation from initialisation of its_node")
> Signed-off-by: Kemeng Shi <shikemeng@xxxxxxxxxxxxxxx>
> ---
>  drivers/irqchip/irq-gic-v3-its.c | 8 ++++++--
>  1 file changed, 6 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/irqchip/irq-gic-v3-its.c b/drivers/irqchip/irq-gic-v3-its.c
> index d721b6101e0a..3e4edcb64065 100644
> --- a/drivers/irqchip/irq-gic-v3-its.c
> +++ b/drivers/irqchip/irq-gic-v3-its.c
> @@ -5747,9 +5747,13 @@ static int __init gic_acpi_parse_madt_its(union acpi_subtable_headers *header,
>  		its->flags |= ITS_FLAGS_FORCE_NON_SHAREABLE;
>  
>  	err = its_probe_one(its);
> -	if (!err)
> -		return 0;
> +	if (err)
> +		goto probe_err;
> +
> +	return 0;
>  
> +probe_err:
> +	its_node_destroy(its);
>  node_err:
>  	iort_deregister_domain_token(its_entry->translation_id);
>  dom_err:

Reviewed-by: Radu Rendec <radu@xxxxxxxxxx>