Re: [PATCH v2 4/5] iio: adc: ti-adc161s626: log buffer setup failure in probe
From: Prashant Rahul
Date: Sat Jul 04 2026 - 13:29:01 EST
On Sat Jul 4, 2026 at 10:30 PM IST, Andy Shevchenko wrote:
> On Sat, Jul 04, 2026 at 09:20:46PM +0530, Prashant Rahul wrote:
>> On Fri Jul 3, 2026 at 6:09 AM IST, Jonathan Cameron wrote:
>> > For now I've picked up the two straight conversions to dev_err_probe()
>> > because I'm keen to (slowly) stop using dev_err() in probe functions.
>>
>> I can look for places where dev_err() is used and can be replaced with
>> dev_err_probe() in other probe functions, then create a new patch
>> series for it. Without adding new logs or removing any existing ones, of course.
>> Shouldn't take a lot of time, what do you think?
>
> In some cases it would make an additional churn. Each driver may require
> a unique set of the cleanups and refactoring patches. Better to do something
> that you have HW to test on.
Makes sense.
> I also removed some people from the Cc list. Why did you add them?
I am a little confused here. I only added people to the CC list who were
already present in the CC list of the original email. Am I missing
something?
regards,
Prashant Rahul