Re: [PATCH v2] media: atomisp: flatten pre_power_down logic and clean up staging code
From: Andy Shevchenko
Date: Sun Jul 05 2026 - 02:50:19 EST
On Sun, Jul 05, 2026 at 12:08:54AM +0500, Ruziev Miraly wrote:
> Refactor atomisp_mrfld_pre_power_down() by removing the redundant
> nested 'else' block, making the function structure linear and easier
> to follow. Keep both error logging branches intact to ensure consistency
> in hardware failure reporting.
>
> In addition, fix minor checkpatch.pl style warnings in the same file
> regarding code alignment and hanging open parentheses.
> ---
> Changes in v2:
As I see this went completely wrong. Read my previous reply why.
Please, slow down and take your time to study how the Git works
and what is the process to upstream the changes and read related
(in-kernel) documentation for that (also articles from lwn.net
will be helpful).
On top of that, find a hardware to test your changes. It's usually quite cheap
no-name Intel Bay Trail or Intel Cherry Trail tablets one may find.
--
With Best Regards,
Andy Shevchenko