Re: [PATCH 0/7] Finish removing crypto_rng from drivers/crypto/

[Herbert Xu]

On Mon, Jun 15, 2026 at 03:41:24PM -0700, Eric Biggers wrote:
> This series finishes removing the unused, redundant, and frequently
> broken crypto_rng support from drivers/crypto/.  It applies to
> cryptodev/master.
> 
> Patches 1-4 are a resend of
> https://lore.kernel.org/linux-crypto/20260608175848.2045229-1-ebiggers@xxxxxxxxxx/
> 
> Please consider these patches for 7.2, considering that most of these
> drivers had security vulnerabilities which would have needed to be fixed
> right away anyway.  And the qcom hwrng fixes are important too.
> 
> Eric Biggers (7):
>   crypto: qcom-rng - Enable clock in hwrng case
>   crypto: qcom-rng - Allow zero as a random number
>   crypto: qcom-rng - Remove crypto_rng interface
>   hwrng: qcom - Move qcom-rng.c into drivers/char/hw_random/
>   crypto: sun8i-ce - Remove crypto_rng interface
>   crypto: sun8i-ss - Remove crypto_rng interface
>   crypto: caam - Remove crypto_rng interface
> 
>  arch/arm/configs/multi_v7_defconfig           |   2 +-
>  arch/arm/configs/qcom_defconfig               |   2 +-
>  arch/arm64/configs/defconfig                  |   2 +-
>  drivers/char/hw_random/Kconfig                |  11 +
>  drivers/char/hw_random/Makefile               |   1 +
>  drivers/{crypto => char/hw_random}/qcom-rng.c | 156 ++----------
>  drivers/crypto/Kconfig                        |  12 -
>  drivers/crypto/Makefile                       |   1 -
>  drivers/crypto/allwinner/Kconfig              |  16 --
>  drivers/crypto/allwinner/sun8i-ce/Makefile    |   1 -
>  .../crypto/allwinner/sun8i-ce/sun8i-ce-core.c |  63 -----
>  .../crypto/allwinner/sun8i-ce/sun8i-ce-prng.c | 159 ------------
>  drivers/crypto/allwinner/sun8i-ce/sun8i-ce.h  |  29 ---
>  drivers/crypto/allwinner/sun8i-ss/Makefile    |   1 -
>  .../crypto/allwinner/sun8i-ss/sun8i-ss-core.c |  45 ----
>  .../crypto/allwinner/sun8i-ss/sun8i-ss-prng.c | 177 -------------
>  drivers/crypto/allwinner/sun8i-ss/sun8i-ss.h  |  23 --
>  drivers/crypto/caam/Kconfig                   |   9 -
>  drivers/crypto/caam/Makefile                  |   1 -
>  drivers/crypto/caam/caamprng.c                | 241 ------------------
>  drivers/crypto/caam/intern.h                  |  15 --
>  drivers/crypto/caam/jr.c                      |   2 -
>  drivers/gpu/drm/ci/arm64.config               |   2 +-
>  23 files changed, 41 insertions(+), 930 deletions(-)
>  rename drivers/{crypto => char/hw_random}/qcom-rng.c (53%)
>  delete mode 100644 drivers/crypto/allwinner/sun8i-ce/sun8i-ce-prng.c
>  delete mode 100644 drivers/crypto/allwinner/sun8i-ss/sun8i-ss-prng.c
>  delete mode 100644 drivers/crypto/caam/caamprng.c
> 
> 
> base-commit: 6ea0ce3a19f9c37a014099e2b0a46b27fa164564

Patches 4-7 applied.  Thanks.
-- 
Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt