Re: [PATCH v4 1/8] crypto: qce - Remove unsafe/deprecated algorithms

[Herbert Xu]

On Mon, Jun 22, 2026 at 03:18:09PM +0200, Bartosz Golaszewski wrote:
> Remove algorithms that are either unsafe or deprecated and have no
> in-kernel users that cannot be served by the ARM CE implementations.
> 
> AES-ECB reveals plaintext patterns (identical plaintext blocks produce
> identical ciphertext blocks) and should not be exposed as a hardware-
> accelerated primitive. DES, Triple DES and HMAC-SHA1 have been
> deprecated for years.
> 
> Remove sha1, ecb(aes), ecb(des), cbc(des), ecb(des3_ede), cbc(des3_ede),
> hmac(sha1) and all AEAD variants built on these primitives as well as
> authenc(hmac(sha256),cbc(des)). Also clean up the - now dead - code,
> flags and constants.
> 
> Cc: stable@xxxxxxxxxxxxxxx
> Acked-by: Eric Biggers <ebiggers@xxxxxxxxxx>
> Tested-by: Kuldeep Singh <kuldeep.singh@xxxxxxxxxxxxxxxx>
> Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@xxxxxxxxxxxxxxxx>
> ---
>  drivers/crypto/qce/aead.c     | 56 +------------------------
>  drivers/crypto/qce/common.c   | 55 ++++++------------------
>  drivers/crypto/qce/common.h   | 16 ++-----
>  drivers/crypto/qce/regs-v5.h  |  4 --
>  drivers/crypto/qce/sha.c      | 30 +------------
>  drivers/crypto/qce/sha.h      |  1 -
>  drivers/crypto/qce/skcipher.c | 97 +------------------------------------------
>  7 files changed, 20 insertions(+), 239 deletions(-)

Patch applied.  Thanks.
-- 
Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt