Regression: ACPI battery status incorrectly reported as Not charging after bb1256e0ddc7

[golne tree]

Dear ACPI maintainers,

I would like to report a regression caused by commit:

bb1256e0ddc7 ("ACPI: battery: fix incorrect charging status when current is zero")

The commit fixes a real issue on Huawei laptops, but it appears to introduce a regression on my system.

Hardware:

Manufacturer: Default string
Product: Default string
Laptop: Denver NID-14106SSDDE
Kernel: 7.0.11-1-cachyos
The same issue is also present with the unmodified Fedora Workstation kernel.

Observed behavior:

When the AC adapter is connected, the battery is actually charging. The battery percentage increases

However, the kernel reports:

POWER_SUPPLY_STATUS=Not charging
POWER_SUPPLY_POWER_NOW=0

Relevant values from /sys/class/power_supply/BAT0/uevent:

POWER_SUPPLY_STATUS=Not charging
POWER_SUPPLY_POWER_NOW=0
POWER_SUPPLY_VOLTAGE_NOW=7400000
POWER_SUPPLY_ENERGY_NOW=24760000
POWER_SUPPLY_CAPACITY=84

The battery does not provide current_now, and DMI information is unfortunately only:

system-manufacturer: Default string
system-product-name: Default string

Looking at commit bb1256e0ddc7, the following logic was introduced:

if (battery->rate_now != ACPI_BATTERY_VALUE_UNKNOWN &&
    battery->rate_now == 0)
        status = POWER_SUPPLY_STATUS_NOT_CHARGING;

On my system, rate_now is always reported as zero even while the battery is clearly charging. As a result, userspace always receives Not charging, although the battery level continues to increase.

This suggests that some firmware reports an incorrect rate_now value while still charging, making the new heuristic unsuitable for all systems.

Please let me know if you need additional information (acpidump, DSDT, debug logs, etc.). I would be happy to provide them.

Thank you for your time.

Best regards,
Goldi Tree