Re: [PATCH v4 04/10] remoteproc: qcom: pas: add support for TMD thermal cooling devices

[Gaurav Kohli]

On 7/3/2026 1:26 PM, Krzysztof Kozlowski wrote:
> On Fri, Jul 03, 2026 at 10:33:07AM +0530, Gaurav Kohli wrote:
> > +	tmd_inst = qmi_tmd_init(pas->dev, desc->tmd_instance_id, tmd_names, desc->num_tmd);
> > +	if (IS_ERR(tmd_inst)) {
> > +		ret = PTR_ERR(tmd_inst);
> > +		if (ret == -ENODEV)
> > +			return 0;
> > +
> > +		dev_err(pas->dev, "Failed to initialize TMD: %d\n", ret);
>
> You already print error msg in qmi_tmd_init(), no?

thanks for review, this looks redundant. will drop it.

> Is this probe path (looks like)? If so, why aren't you using
> dev_err_probe()?
>
> > +		return ret;
> > +	}
> > +
> > +	pas->tmd_inst = tmd_inst;
> > +
> > +	return 0;
>
> Best regards,
> Krzysztof