Re: [PATCH v7 024/120] x86/cpu/zhaoxin: Use parsed CPUID(0xc0000001)

[Borislav Petkov]

On Thu, May 28, 2026 at 05:37:46PM +0200, Ahmed S. Darwish wrote:
> Use parsed CPUID(0xc0000001).
> 
> Beside the CPUID parser centralization benefits, this allows using the
> auto-generated x86-cpuid-db data types, and their full C99 bitfields,
> instead of doing ugly bitwise operations on the CPUID output.
> 
> Keep the x86_capability[] CPUID(0xc0000001).EDX assignment.  It will be
> removed once X86_FEATURE translation is integrated into the CPUID model.
> 
> Signed-off-by: Ahmed S. Darwish <darwi@xxxxxxxxxxxxx>
> ---
>  arch/x86/kernel/cpu/zhaoxin.c | 19 +++++--------------
>  1 file changed, 5 insertions(+), 14 deletions(-)

Same review notes as about the previous patch.

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette