Re: [PATCH v5 2/2] PM: dpm_watchdog: Allow disabling DPM watchdog by default

[Tzung-Bi Shih]

On Wed, Jul 01, 2026 at 09:20:46AM +0200, Greg Kroah-Hartman wrote:
> On Wed, Jul 01, 2026 at 04:56:40AM +0000, Tzung-Bi Shih wrote:
> > diff --git a/kernel/power/Kconfig b/kernel/power/Kconfig
> > index 530c897311d4..508ceabc4d2e 100644
> > --- a/kernel/power/Kconfig
> > +++ b/kernel/power/Kconfig
> > @@ -268,6 +268,16 @@ config DPM_WATCHDOG
> >  	  captured in pstore device for inspection in subsequent
> >  	  boot session.
> >  
> > +config DPM_WATCHDOG_ENABLED
> > +	bool "Enable DPM watchdog by default"
> > +	depends on DPM_WATCHDOG
> > +	default y
> 
> Only do this if you can not boot without the option enabled, which I do
> not think is the case here.

I assume you are referring to the `default y`?

The reason for adding `default y` here is to maintain backward compatibility.
Previously, the DPM watchdog was always active if CONFIG_DPM_WATCHDOG was set.
By defaulting this new option to 'y', we ensure that the behavior remains
unchanged for existing users and defconfigs when they upgrade.

At the same time, this new option provides the flexibility for systems
(like Android GKI) that want to compile the watchdog code in, but keep it
disabled by default.