Re: [PATCH v3 10/14] vfs: move O_IS_MKDIR check from lookup_open() into individual filesystems

[NeilBrown]

On Sun, 05 Jul 2026, Jori Koolstra wrote:
> Individual filesystems that implement ->atomic_open() need to get the
> chance to implement O_CREAT|O_DIRECTORY or not, rather than decide
> this at the VFS level in lookup_open().
> 
> Signed-off-by: Jori Koolstra <jkoolstra@xxxxxxxxx>

This look straight forward.

Reviewed-by: NeilBrown <neil@xxxxxxxxxx>

Thanks,
NeilBrown


> ---
>  fs/9p/vfs_inode.c      | 3 +++
>  fs/9p/vfs_inode_dotl.c | 3 +++
>  fs/ceph/file.c         | 3 +++
>  fs/fuse/dir.c          | 3 +++
>  fs/gfs2/inode.c        | 3 +++
>  fs/namei.c             | 3 ---
>  fs/nfs/dir.c           | 6 ++++++
>  fs/smb/client/dir.c    | 3 +++
>  fs/vboxsf/dir.c        | 3 +++
>  9 files changed, 27 insertions(+), 3 deletions(-)
> 
> diff --git a/fs/9p/vfs_inode.c b/fs/9p/vfs_inode.c
> index 5783d0336f96..bb555e5ba261 100644
> --- a/fs/9p/vfs_inode.c
> +++ b/fs/9p/vfs_inode.c
> @@ -777,6 +777,9 @@ v9fs_vfs_atomic_open(struct inode *dir, struct dentry *dentry,
>  	struct inode *inode;
>  	int p9_omode;
>  
> +	if (O_IS_MKDIR(flags))
> +		flags &= ~O_CREAT;
> +
>  	if (d_in_lookup(dentry)) {
>  		struct dentry *res = v9fs_vfs_lookup(dir, dentry, 0);
>  		if (res || d_really_is_positive(dentry))
> diff --git a/fs/9p/vfs_inode_dotl.c b/fs/9p/vfs_inode_dotl.c
> index f7396d20cb6c..ff3facb420c2 100644
> --- a/fs/9p/vfs_inode_dotl.c
> +++ b/fs/9p/vfs_inode_dotl.c
> @@ -239,6 +239,9 @@ v9fs_vfs_atomic_open_dotl(struct inode *dir, struct dentry *dentry,
>  	struct v9fs_session_info *v9ses;
>  	struct posix_acl *pacl = NULL, *dacl = NULL;
>  
> +	if (O_IS_MKDIR(flags))
> +		flags &= ~O_CREAT;
> +
>  	if (d_in_lookup(dentry)) {
>  		struct dentry *res = v9fs_vfs_lookup(dir, dentry, 0);
>  		if (res || d_really_is_positive(dentry))
> diff --git a/fs/ceph/file.c b/fs/ceph/file.c
> index 71161f2b2151..e79abdbd9f61 100644
> --- a/fs/ceph/file.c
> +++ b/fs/ceph/file.c
> @@ -811,6 +811,9 @@ int ceph_atomic_open(struct inode *dir, struct dentry *dentry,
>  	      dir, ceph_vinop(dir), dentry, dentry,
>  	      d_unhashed(dentry) ? "unhashed" : "hashed", flags, mode);
>  
> +	if (O_IS_MKDIR(flags))
> +		flags &= ~O_CREAT;
> +
>  	if (dentry->d_name.len > NAME_MAX)
>  		return -ENAMETOOLONG;
>  
> diff --git a/fs/fuse/dir.c b/fs/fuse/dir.c
> index 0e2a1039fa43..e01869565d5e 100644
> --- a/fs/fuse/dir.c
> +++ b/fs/fuse/dir.c
> @@ -935,6 +935,9 @@ static int fuse_atomic_open(struct inode *dir, struct dentry *entry,
>  	struct mnt_idmap *idmap = file_mnt_idmap(file);
>  	struct fuse_conn *fc = get_fuse_conn(dir);
>  
> +	if (O_IS_MKDIR(flags))
> +		flags &= ~O_CREAT;
> +
>  	if (fuse_is_bad(dir))
>  		return -EIO;
>  
> diff --git a/fs/gfs2/inode.c b/fs/gfs2/inode.c
> index 8a77794bbd4a..9859ae0341a9 100644
> --- a/fs/gfs2/inode.c
> +++ b/fs/gfs2/inode.c
> @@ -1387,6 +1387,9 @@ static int gfs2_atomic_open(struct inode *dir, struct dentry *dentry,
>  {
>  	bool excl = !!(flags & O_EXCL);
>  
> +	if (O_IS_MKDIR(flags))
> +		flags &= ~O_CREAT;
> +
>  	if (d_in_lookup(dentry)) {
>  		struct dentry *d = __gfs2_lookup(dir, dentry, file);
>  		if (file->f_mode & FMODE_OPENED) {
> diff --git a/fs/namei.c b/fs/namei.c
> index 5113ac986f50..76916caa264d 100644
> --- a/fs/namei.c
> +++ b/fs/namei.c
> @@ -4497,9 +4497,6 @@ static struct dentry *lookup_open(struct nameidata *nd, struct file *file,
>  	if (unlikely(IS_DEADDIR(dir_inode)))
>  		return ERR_PTR(-ENOENT);
>  
> -	if (O_IS_MKDIR(open_flag) && dir_inode->i_op->atomic_open)
> -		open_flag &= ~O_CREAT;
> -
>  	file->f_mode &= ~FMODE_CREATED;
>  	dentry = d_lookup(dir, &nd->last);
>  	for (;;) {
> diff --git a/fs/nfs/dir.c b/fs/nfs/dir.c
> index c7b723c18620..c815d9aa9b69 100644
> --- a/fs/nfs/dir.c
> +++ b/fs/nfs/dir.c
> @@ -2121,6 +2121,9 @@ int nfs_atomic_open(struct inode *dir, struct dentry *dentry,
>  	dfprintk(VFS, "NFS: atomic_open(%s/%llu), %pd\n",
>  			dir->i_sb->s_id, dir->i_ino, dentry);
>  
> +	if (O_IS_MKDIR(open_flags))
> +		open_flags &= ~O_CREAT;
> +
>  	err = nfs_check_flags(open_flags);
>  	if (err)
>  		return err;
> @@ -2313,6 +2316,9 @@ int nfs_atomic_open_v23(struct inode *dir, struct dentry *dentry,
>  	 */
>  	int error = 0;
>  
> +	if (O_IS_MKDIR(open_flags))
> +		open_flags &= ~O_CREAT;
> +
>  	if (dentry->d_name.len > NFS_SERVER(dir)->namelen)
>  		return -ENAMETOOLONG;
>  
> diff --git a/fs/smb/client/dir.c b/fs/smb/client/dir.c
> index 88a4a1787ff0..75bf86cc0612 100644
> --- a/fs/smb/client/dir.c
> +++ b/fs/smb/client/dir.c
> @@ -538,6 +538,9 @@ int cifs_atomic_open(struct inode *dir, struct dentry *direntry,
>  	if (unlikely(cifs_forced_shutdown(cifs_sb)))
>  		return smb_EIO(smb_eio_trace_forced_shutdown);
>  
> +	if (O_IS_MKDIR(oflags))
> +		oflags &= ~O_CREAT;
> +
>  	/*
>  	 * Posix open is only called (at lookup time) for file create now. For
>  	 * opens (rather than creates), because we do not know if it is a file
> diff --git a/fs/vboxsf/dir.c b/fs/vboxsf/dir.c
> index c5bd3271aa96..77ae2f696fd4 100644
> --- a/fs/vboxsf/dir.c
> +++ b/fs/vboxsf/dir.c
> @@ -318,6 +318,9 @@ static int vboxsf_dir_atomic_open(struct inode *parent, struct dentry *dentry,
>  	u64 handle;
>  	int err;
>  
> +	if (O_IS_MKDIR(flags))
> +		flags &= ~O_CREAT;
> +
>  	if (d_in_lookup(dentry)) {
>  		struct dentry *res = vboxsf_dir_lookup(parent, dentry, 0);
>  		if (res || d_really_is_positive(dentry))
> -- 
> 2.55.0
> 
>