Re: [PATCH v5 2/2] media: i2c: imx678: Add driver for Sony IMX678
From: Tarang Raval
Date: Mon Jul 06 2026 - 04:30:24 EST
Hi Jai,
> Add a V4L2 subdev driver for the Sony IMX678 image sensor.
>
> IMX678 is a diagonal 8.86 mm (Type 1/1.8) CMOS active pixel type
> solid-state image sensor with a square pixel array and 8.40 M effective
> pixels.
>
> The following features are supported by this driver:
> - MIPI RAW12 output
> - Monochrome and Color (Bayer filter) variants
> - Multiple input clock frequencies
> - Multiple link frequencies
> - VBLANK and HBLANK control for variable framerate
> - VFLIP and HFLIP control for flipping readout
> - Exposure and analogue gain control
> - Test pattern control
>
> Following features are not currently supported:
> - MIPI RAW10 output
> - Pixel-perfect crop reporting, accounting for the shift-by-1 when
> doing HFLIP/VFLIP where the sensor maintains RGGB bayer ordering
>
> Along with the ones below which depend on the new raw sensor model:
> - Embedded data stream
> - Freely configurable cropping
> - Increased framerate when cropping
> - 2x2 binning support
>
> Signed-off-by: Jai Luthra <jai.luthra@xxxxxxxxxxxxxxxx>
> ---
...
> +static int imx678_enum_mbus_code(struct v4l2_subdev *sd,
> + struct v4l2_subdev_state *sd_state,
> + struct v4l2_subdev_mbus_code_enum *code)
> +{
> + struct imx678 *imx678 = to_imx678(sd);
> +
> + if (code->index >= imx678->info->num_codes)
> + return -EINVAL;
> +
> + code->code = imx678->info->codes[code->index];
A blank line is needed before the return 0;
> + return 0;
> +}
I think there is no need for a new revision for this minor style fix.
It can be addressed during the merge.
Reviewed-by: Tarang Raval <tarang.raval@xxxxxxxxxxxxxxxxx>
Best regards,
Tarang