Re: [PATCH v1 4/5] pwm: Unify coding style of of_device_id arrays

From: Philippe Mathieu-Daudé

Date: Mon Jul 06 2026 - 04:32:11 EST


Hi Uwe,

On 6/7/26 09:19, Uwe Kleine-König (The Capable Hub) wrote:
Hello Chen,

On Mon, Jul 06, 2026 at 08:33:47AM +0800, Chen Wang wrote:
On 7/5/2026 11:14 PM, Uwe Kleine-König (The Capable Hub) wrote:
- Use a single space in a of_device_id array terminator; A single space
after the opening { and before the closing } in non-empty
initializers;
- No comma after an array terminator;
- Also no trailing comma after a named initializer iff the
iff -> if

This is actually intended. iff = "if and only if", see e.g.
https://en.wikipedia.org/wiki/If_and_only_if .

I agree this scientific idiomatic expression is not well known
by non-native English speakers, and using the expanded form is
just simpler to review (thinking at non-native English speaker
reading your commit in the future).


closing } is on the same line;

Signed-off-by: Uwe Kleine-König (The Capable Hub) <u.kleine-koenig@xxxxxxxxxxxx>

[......]