Re: [PATCH v2] virtio_balloon: prime stats vq after virtio_device_ready()

From: David Hildenbrand (Arm)

Date: Mon Jul 06 2026 - 04:38:47 EST


>>> - virtqueue_kick(vb->stats_vq);
>>> + disable_work(&vb->update_balloon_stats_work);
>>
>> That's to stop the stats queue triggering stats_request() I assume?
>
> Yes.
>
>> Is that
>> valid before we actually added+kicked ourselves?
>
> Why not?

I was wondering whether the spec would state something about that.

>
>> Also, can't we simply handle that in stats_request(), just ignoring it there?
>
> Then we'd need to maintain a special flag and I dislike that.

I was hoping that we could use the device-ready indication, but there would be a
small race window indeed.

--
Cheers,

David