Re: [PATCH v2 13/24] ASoC: codecs: cs35l56: Use guard() and PM runtime scope helpers

[Bui Duc Phuc]

Hi Cezary, Richard,

Thanks to both of you for the reviews!

> > -     ret = IRQ_HANDLED;
> > +     return IRQ_HANDLED;
> >
> > -err:
> > -     pm_runtime_put(cs35l56_base->dev);
> > -err_unlock:
> > -     mutex_unlock(&cs35l56_base->irq_lock);
> > -
> > -     return ret;
> >   }
> Nitpick: this will leave a superfluous newline.

You're right. I'll remove the extra blank line.

> It looks like a bug that it checks rv but returns ret.

I'm not sure I fully understand what you meant by that comment. This
conversion preserves the existing behavior, so although checking rv
and returning ret may look a bit odd, I don't think it changes the
behavior or introduces a bug.

> The local ret variable can be deleted.
> Should change all the error returns to directly return IRQ_NONE.

As you suggested,
I'll remove the ret variable entirely and return IRQ_NONE /
IRQ_HANDLED directly.

Best regards,
Phuc