Re: [PATCH v5 2/5] thermal/drivers/sun8i: replace devm_reset_control_get to devm_reset_control_get_shared_deasserted

[Philipp Zabel]

On So, 2026-07-05 at 01:14 +0800, Mikhail Kalashnikov wrote:
> The A523 processor has two temperature controllers, but they share a
> common reset line. Make it shared with the shared variant of
> devm_reset_control_get(), and also simplify the driver by switching to
> devm_reset_control_get_shared_deasserted().
> 
> Signed-off-by: Mikhail Kalashnikov <iuncuim@xxxxxxxxx>
> Reviewed-by: Chen-Yu Tsai <wens@xxxxxxxxxx>
> ---
>  drivers/thermal/sun8i_thermal.c | 16 +---------------
>  1 file changed, 1 insertion(+), 15 deletions(-)
> 
> diff --git a/drivers/thermal/sun8i_thermal.c b/drivers/thermal/sun8i_thermal.c
> index 226747906..df0c26970 100644
> --- a/drivers/thermal/sun8i_thermal.c
> +++ b/drivers/thermal/sun8i_thermal.c
> @@ -342,11 +342,6 @@ static int sun8i_ths_calibrate(struct ths_device *tmdev)
>  	return ret;
>  }
>  
> -static void sun8i_ths_reset_control_assert(void *data)
> -{
> -	reset_control_assert(data);
> -}
> -
>  static struct regmap *sun8i_ths_get_sram_regmap(struct device_node *node)
>  {
>  	struct platform_device *sram_pdev;
> @@ -389,19 +384,10 @@ static int sun8i_ths_resource_init(struct ths_device *tmdev)
>  		return PTR_ERR(tmdev->regmap);
>  
>  	if (tmdev->chip->has_bus_clk_reset) {
> -		tmdev->reset = devm_reset_control_get(dev, NULL);
> +		tmdev->reset = devm_reset_control_get_shared_deasserted(dev, NULL);

Nothing wrong with your patch, but why is this stored on struct
ths_device at all? It's never used. You could turn this into a local
variable while you're at it. Either way,

Reviewed-by: Philipp Zabel <p.zabel@xxxxxxxxxxxxxx>


regards
Philipp