Re: [PATCH v4 1/5] media: qcom: camss: Populate CAMSS child devices via DT

[Krzysztof Kozlowski]

On 06/07/2026 14:27, Bryan O'Donoghue wrote:
> On 06/07/2026 13:09, Krzysztof Kozlowski wrote:
>> On 06/07/2026 09:11, Atanas Filipov wrote:
>>> From: Bryan O'Donoghue <bryan.odonoghue@xxxxxxxxxx>
>>>
>>> Use devm_of_platform_populate() so that child nodes declared under the
>>> CAMSS device tree node (e.g. OPE) are automatically instantiated as
>>> platform devices. This is required now that CAMSS is modelled as a
>>> simple-bus and ISP blocks such as OPE are described as child nodes.
>>
>> I do not understand this rationale. How is this required now? Are
>> existing DTS broken and do not work? Then this needs to be explained.
> 
> Required is wrong, true. Existing DT is not broken no.
> 
> Should read something like:
> 
> "Use devm_of_platform_populate() so that child nodes declared under the 
> CAMSS device tree node (e.g. OPE) are automatically instantiated as 
> platform devices."

This patch then makes no sense before the binding defines such children.

If you carry this patch outside of this work, you do not need to keep
the Nacked-by tag. Only constant ignoring of review here is the reason
of Nacked-by.

However if you carry this patch separately, you still need to fix the
lack of sense of doing this at this point.

Best regards,
Krzysztof