Re: [RFC PATCH 0/3] mtd: spi-nor: Rework flash parameter initialization

[Miquel Raynal]

Hello,

On 06/07/2026 at 09:33:38 +02, "Michael Walle" <mwalle@xxxxxxxxxx> wrote:

> On Mon Jul 6, 2026 at 8:24 AM CEST, Miquel Raynal wrote:
>> On Mon, 01 Jun 2026 14:52:42 +0200, Michael Walle wrote:
>>> Try to simplify the flash initialization and get rid of the legacy
>>> handling. As default, all the flags of the in-kernel database are
>>> taken and amended with the SFDP data.
>>> 
>>> This might have the consequence that all the flashes now get a
>>> RDSFPD opcode which might be an unknown opcode. But that was already
>>> the case for any flashes which were unknown to the linux kernel. So
>>> far, there was not a single complaint.
>>> 
>>> [...]
>>
>> Applied to mtd/fixes, thanks!
>>
>> [1/3] mtd: spi-nor: spansion: s25fl256s0: remove SKIP_SFDP flag
>>       (no commit info)
>> [2/3] mtd: spi-nor: don't clear the SNOR_F_4B_OPCODES flag on failure
>>       (no commit info)
>> [3/3] mtd: spi-nor: rework flash parameter initialization
>>       (no commit info)
>>
>> Patche(s) should be available on mtd/linux.git and will be
>> part of the next PR (provided that no robot complains by then).
>
> Did you see, that there was a v1 of this series? There wasn't many
> changes for these three patches. Just what Tudor mentioned that the
> unsupported RDSFDP opcode should be mentioned in the commit message,
> too.
>
> Apart from that, the series now includes fixes that Sashiko found,
> that is, the rollback in case of a failed SFDP parsing is broken. I
> can also rebase that on top of these three patches.

Sorry, I actually applied it last Friday and pushed only this morning. I
will drop the patches and apply v1.

Thanks,
Miquèl