Re: [PATCH v2 1/5] dt-bindings: hwmon: (pmbus/max20830): add enable-gpios property and complete examples

[Guenter Roeck]

On 7/6/26 00:13, Torreno, Alexis Czezar wrote:
> > On Mon, Jul 06, 2026 at 10:08:41AM +0800, Alexis Czezar Torreno wrote:
> > > Adding an entry for the MAX20830 EN (enable) pin. This pin exist but
> > > was not included before. Also edited examples entry to be more complete.
> > >
> > > Signed-off-by: Alexis Czezar Torreno <alexisczezar.torreno@xxxxxxxxxx>
> > > ---
> > >   .../devicetree/bindings/hwmon/pmbus/adi,max20830.yaml         | 11
> > +++++++++++
> > >   1 file changed, 11 insertions(+)
> >
> > How did you address previous feedback?
>
> Regarding the enable pin, I added this since I know bindings like being complete
> and saw that I didn't add it the first time I submitted max20830.
> I added driver code for the gpio but learned that it wasn't really a use case so
> I simply dropped the patch for it.

I guess I am completely missing the point here. I can not imagine a situation
where one would want to connect the enable pin to a driver-controlled GPIO pin,
or why would one connect the chip's PGOOD output pin to a GPIO input pin
and connect that back to the driver.

I think we will need guidance from devicetree maintainers explaining what
"complete" means in such a context to avoid having to repeat this discussion
for every driver going forward.

Thanks,
Guenter