Re: [PATCH] hwmon: emc2103: use min_t() for explicit type in fan target clamp

[Guenter Roeck]

On 7/6/26 09:25, Animesh Rai wrote:
> Using min() with an explicit cast on one operand is fragile. Replace
> with min_t(u16, ...) to make the intended comparison type explicit and
> avoid implicit type conversion.

Sorry, I have no idea what you are trying to fix here. Both parameters
are u16. There is nothing "fragile" about that.

Guenter

> Signed-off-by: Animesh Rai <animeshrai853@xxxxxxxxx>
> ---
>   drivers/hwmon/emc2103.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/hwmon/emc2103.c b/drivers/hwmon/emc2103.c
> index 27dc149a3ed9..fbb1b4025eb7 100644
> --- a/drivers/hwmon/emc2103.c
> +++ b/drivers/hwmon/emc2103.c
> @@ -348,7 +348,7 @@ static ssize_t fan1_div_store(struct device *dev, struct device_attribute *da,
>   	/* update fan target if high byte is not disabled */
>   	if ((data->fan_target & 0x1fe0) != 0x1fe0) {
>   		u16 new_target = (data->fan_target * old_div) / new_div;
> -		data->fan_target = min(new_target, (u16)0x1fff);
> +		data->fan_target = min_t(u16, new_target, 0x1fff);
>   		write_fan_target_to_i2c(client, data->fan_target);
>   	}
>