Re: [PATCH v3 1/4] dt-bindings: phy: motorola,cpcap-usb: add chrg_det interrupt

[Ivaylo Dimitrov]

Hi,

On 6.07.26 г. 20:14 ч., Conor Dooley wrote:
> On Sun, Jul 05, 2026 at 01:11:02PM +0300, Ivaylo Dimitrov wrote:
> > The CPCAP USB PHY driver uses the CPCAP charger detection interrupt
> > for DCP detection.
>
> This is not currently true, the driver does not look for this interrupt
> at the time of this patch.

Right, this is bad wording caused by the fact that initially the driver 
patch came before the binding patch.

> > Update the binding and example DTS to use the corresponding
> > "chrg_det" interrupt name.
>
> Sounds to me like this new interrupt is optional, since until now it has
> not been needed? The patch however makes it mandatory. I think your
> driver patch also makes it mandatory, which will break older
> devicetrees.

Oh, it is indeed not needed for proper DCP/SDP detection, after some 
experiments I was able to teach the driver to do proper detection by 
using current interrupts only.

> What makes this ABI break okay?

Will send new series with schema/DT patches dropped.

Thanks and regards,
Ivo

> Thanks,
> Conor.
>
> > Signed-off-by: Ivaylo Dimitrov <ivo.g.dimitrov.75@xxxxxxxxx>
> > ---
> >   .../devicetree/bindings/phy/motorola,cpcap-usb-phy.yaml     | 6 ++++--
> >   1 file changed, 4 insertions(+), 2 deletions(-)
> >
> > diff --git a/Documentation/devicetree/bindings/phy/motorola,cpcap-usb-phy.yaml b/Documentation/devicetree/bindings/phy/motorola,cpcap-usb-phy.yaml
> > index 0febd04a61f4..523a8f8480d0 100644
> > --- a/Documentation/devicetree/bindings/phy/motorola,cpcap-usb-phy.yaml
> > +++ b/Documentation/devicetree/bindings/phy/motorola,cpcap-usb-phy.yaml
> > @@ -30,6 +30,7 @@ properties:
> >         - description: se1 interrupt
> >         - description: dm interrupt
> >         - description: dp interrupt
> > +      - description: charger detection interrupt
> >   
> >     interrupt-names:
> >       description: Interrupt names
> > @@ -43,6 +44,7 @@ properties:
> >         - const: se1
> >         - const: dm
> >         - const: dp
> > +      - const: chrg_det
> >   
> >     io-channels:
> >       description: IIO ADC channels used by the USB PHY
> > @@ -91,10 +93,10 @@ examples:
> >           interrupts-extended = <
> >               &cpcap 15 0 &cpcap 14 0 &cpcap 28 0 &cpcap 19 0
> >               &cpcap 18 0 &cpcap 17 0 &cpcap 16 0 &cpcap 49 0
> > -            &cpcap 48 1
> > +            &cpcap 48 1 &cpcap 13 0
> >           >;
> >           interrupt-names = "id_ground", "id_float", "se0conn", "vbusvld",
> > -                          "sessvld", "sessend", "se1", "dm", "dp";
> > +                          "sessvld", "sessend", "se1", "dm", "dp", "chrg_det";
> >           io-channels = <&cpcap_adc 2>, <&cpcap_adc 7>;
> >           io-channel-names = "vbus", "id";
> >           vusb-supply = <&vusb>;
> > --
> > 2.39.5