RE: [PATCH 09/10] EDAC/igen6: Remove redundant resource configuration tables

[Zhuo, Qiuxu]

Hi Tony,

> From: Luck, Tony <tony.luck@xxxxxxxxx>
> Sent: Tuesday, July 7, 2026 7:29 AM
> To: Zhuo, Qiuxu <qiuxu.zhuo@xxxxxxxxx>
> Cc: Borislav Petkov <bp@xxxxxxxxx>; Lai, Yi1 <yi1.lai@xxxxxxxxx>; linux-
> edac@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx
> Subject: Re: [PATCH 09/10] EDAC/igen6: Remove redundant resource
> configuration tables
> 
> On Mon, Jul 06, 2026 at 11:22:32AM +0800, Qiuxu Zhuo wrote:
> > Several resource configuration tables differ only in their num_imc
> > value, while all other fields are identical. Their only purpose is to
> > describe the number of memory controllers supported by a platform.
> >
> > Since IMC count is now detected at runtime, these duplicate tables no
> > longer carry any unique platform information. Reuse the shared
> > configurations and remove the redundant tables.
> ...
> > +	{ PCI_VDEVICE(INTEL, DID_WCL_SKU1), .driver_data =
> > +(kernel_ulong_t)&mtl_p_cfg },
> 
> Sharing these is good. But also might be confusing since the structure names
> include the three character short form of the CPU name.
> 
> Please add some comments before each structure definition to list which CPU
> models are sharing. E.g.
> 
> /* Shared by Meteor Lake-P, Arrow Lake, Wildcat Lake. */ static struct
> res_config mtl_p_cfg = {  ...
> }

Thanks for the review.
OK, I'll add comments as you suggested in v2.

Thanks!
-Qiuxu