Re: [PATCH] csky: Fix ABIv2 memcmp() s1 alignment check

[Guo Ren]

Hi Song,

On Mon, Jul 6, 2026 at 6:40 PM Hanlin Song <pgeorge8929@xxxxxxxxx> wrote:
>
> Hi Guo Ren and C-SKY maintainers,
>
> Gentle ping on this patch.
>
> My understanding is that r3 holds the original s1 pointer after r0 is
> cleared, so the alignment check should use r3 instead of r0. I also
> tested this on a CK860f chip, and the patched version was faster in my
> unaligned memcmp test.
>
> I may be missing some C-SKY ABIv2 detail, so any feedback would be
> appreciated.
>

Thanks for the patch, but this code is intentional. The CK810 and
CK860 support misaligned load/store in their microarchitecture, so the
alignment-check path is effectively dead code that exists only to keep
this asm code. It has been carried over unchanged from the very first.


-- 
Best Regards
 Guo Ren