Re: [PATCH v2] x86/video: Only fall back to vga_default_device() without screen info

From: Mario Limonciello

Date: Tue Jul 07 2026 - 00:48:03 EST


On 7/6/26 23:18, Borislav Petkov wrote:
On Mon, Jul 06, 2026 at 11:02:04PM -0500, Mario Limonciello wrote:
Those systems use the existing boot_vga sysfs file (which is unchanged).

Userspace recognizes both boot_vga for those systems and boot_display for
modern systems depending upon the use.

You're "explaining" as if I were someone who actually knows anything about
display gunk. But you need to dumb it down for me so that I can actually
understand why we're fine here and we don't need to fallback to
vga_default_device() here, as the LLM has "inferred".

Thx.


OK, let me try.

So a long time ago there was this sysfs attribute introduced for telling which device in the system was used for displaying pre-OS. It mattered when you had multi GPU systems.

It wasn't perfect, but there were enough heuristics put in place that it was good enough.

Userspace would take this as a hint and try to set what it thought was the primary GPU. This has implications for power consumption, what is used for rendering, all sorts of stuff.

Well the heuristics started to break when we started having display adapters that were no longer VGA and those were in multi GPU systems.

Rather than change the heuristics for boot_vga we introduced a new attribute boot_display that indicated which device was used for displaying. This is semantically very similar to boot_vga; but it can apply to any display adapter.

Because userspace has used boot_vga forever and boot_display was new userspace effectively has to support both for two reasons:

1) so that users can mix and match kernels and userspace
2) For the ancient hardware the LLM is complaining about.

So my point here is that even if boot_display fails to be populated on anything in your system (such as reasons the LLM called out) you will still have boot_vga, and userspace still uses boot_vga.