Re:Re: [PATCH v1] fs: fix two spelling mistakes in comments

[Qingshuang Fu]

At 2026-05-28 19:52:19, "Jan Kara" <jack@xxxxxxx> wrote:
>On Wed 27-05-26 11:31:02, fffsqian@xxxxxxx wrote:
>> From: Qingshuang Fu <fuqingshuang@xxxxxxxxxx>
>> 
>> Fix two spelling errors in fs/:
>> - childen  →  children
>> - postion → position
>> 
>> Signed-off-by: Qingshuang Fu <fuqingshuang@xxxxxxxxxx>
>
>Looks good. Feel free to add:
>
>Reviewed-by: Jan Kara <jack@xxxxxxx>
>
>								Honza
>
>> ---
>>  fs/coredump.c | 4 ++--
>>  1 file changed, 2 insertions(+), 2 deletions(-)
>> 
>> diff --git a/fs/coredump.c b/fs/coredump.c
>> index bb6fdb1f458e..f82f6dc4f773 100644
>> --- a/fs/coredump.c
>> +++ b/fs/coredump.c
>> @@ -637,7 +637,7 @@ static int umh_coredump_setup(struct subprocess_info *info, struct cred *new)
>>  		pidfs_coredump(cp);
>>  
>>  		/*
>> -		 * Usermode helpers are childen of either
>> +		 * Usermode helpers are children of either
>>  		 * system_dfl_wq or of kthreadd. So we know that
>>  		 * we're starting off with a clean file descriptor
>>  		 * table. So we should always be able to use
>> @@ -1053,7 +1053,7 @@ static bool coredump_write(struct core_name *cn,
>>  	cn->core_dumped = binfmt->core_dump(cprm);
>>  	/*
>>  	 * Ensures that file size is big enough to contain the current
>> -	 * file postion. This prevents gdb from complaining about
>> +	 * file position. This prevents gdb from complaining about
>>  	 * a truncated file if the last "write" to the file was
>>  	 * dump_skip.
>>  	 */
>> 
>> base-commit: eb3f4b7426cfd2b79d65b7d37155480b32259a11
>> -- 
>> 2.25.1
>> 
>-- 
>Jan Kara <jack@xxxxxxxx>
>SUSE Labs, CR


Hi Jan, Al, Christian,

Thanks Jan for providing the Reviewed-by tag on my original patch.
I sent out v2 one month ago which carries your reviewed-by tag, but there has been no further feedback.

This patch only fixes two trivial spelling typos in coredump comment, no functional logic changes.
Could you help review/merge it when you have spare time?

Reference v2 patch:
https://lore.kernel.org/all/20260529040701.1825238-1-fffsqian@xxxxxxx/

Best regards,
Qingshuang Fu <fuqingshuang@xxxxxxxxxx>