Re: [PATCH v4 01/27] VFIO: take reference to the KVM module
From: Steffen Eiden
Date: Tue Jul 07 2026 - 03:40:35 EST
On Mon, Jul 06, 2026 at 02:12:55PM -0700, Sean Christopherson wrote:
> On Mon, Jul 06, 2026, Jason Gunthorpe wrote:
> > On Mon, Jul 06, 2026 at 10:52:01AM +0200, Steffen Eiden wrote:
> > > From: Paolo Bonzini <pbonzini@xxxxxxxxxx>
> > >
> > > VFIO is implicitly taking a reference to the KVM module between
> > > vfio_device_get_kvm_safe and vfio_device_put_kvm, thanks to
> > > symbol_get and symbol_put.
> >
> > I thought we weren't doing this approach? Use the struct file as the
> > kvm handle. I thought I saw patches doing that already?
>
> +1, my joking-but-serious NAK stands.
>
> https://lore.kernel.org/all/adf29Rn7q9Db0hxc@xxxxxxxxxx
My bad, I did not cover this topic in the cover letter:
I included those tree patches so that the rest of the series links in all configurations.
I know we will not use this approach to mitigate this issue.
Steffen