Re: [PATCH v1] serial: 8250_exar: Consistently define pci_device_ids using named initializers

From: Uwe Kleine-König (The Capable Hub)

Date: Tue Jul 07 2026 - 05:14:42 EST


Hello Greg,

On Fri, May 22, 2026 at 04:01:03PM +0200, Uwe Kleine-König (The Capable Hub) wrote:
> The .driver_data member of the struct pci_device_id array were
> initialized by list expressions. This isn't easily readable if you're
> not into PCI, still more given that it's hidden in macros. Using named
> initializers is more explicit and thus easier to parse for a human. And
> it's also more robust against changes to the struct definition.
>
> The mentioned robustness is relevant for a planned change to struct
> pci_device_id that replaces .driver_data by an anonymous union.
>
> Also drop a few explicit zeros that are not needed and improve
> indention.
>
> This change doesn't introduce changes to the compiled pci_device_id
> array. Tested on x86 and arm64.
>
> Signed-off-by: Uwe Kleine-König (The Capable Hub) <u.kleine-koenig@xxxxxxxxxxxx>

Given this patch was sent around 7.1-rc5 and missed the merge window for
7.2-rc1, I wonder if you still have it on your radar?!

It still applies fine on top of next-20260706.

Best regards
Uwe

Attachment: signature.asc
Description: PGP signature