Re: [PATCH 1/2] staging: rtl8723bs: drop GEN_CMD_CODE macro and capitalize labels
From: Greg Kroah-Hartman
Date: Tue Jul 07 2026 - 07:13:36 EST
On Tue, Jun 09, 2026 at 09:42:55PM -0400, Aiman Najjar wrote:
> The use of GEN_CMD_CODE macro to generate cmd enum label names is applied
> inconsistently and is confusing, it also makes it harder to make use of
> tools such as clangd when looking up symbols.
>
> Replace them with writing the enum labels directly and adopting
> new capitalized names instead of the current camel case ones.
>
> Signed-off-by: Aiman Najjar <aiman@xxxxxxxxx>
> ---
> drivers/staging/rtl8723bs/core/rtw_ap.c | 4 +-
> drivers/staging/rtl8723bs/core/rtw_cmd.c | 190 +++++++++++++-------------
> drivers/staging/rtl8723bs/core/rtw_mlme.c | 4 +-
> drivers/staging/rtl8723bs/core/rtw_mlme_ext.c | 18 +--
> drivers/staging/rtl8723bs/include/rtw_cmd.h | 154 ++++++++++-----------
> 5 files changed, 181 insertions(+), 189 deletions(-)
Does not apply to the latest tree :(