Re: [PATCH] staging: rtl8723bs: fix CamelCase warning for OnAssoc
From: Greg KH
Date: Tue Jul 07 2026 - 07:31:08 EST
On Tue, Jun 23, 2026 at 09:51:00AM +0000, Dalvin-Ehinoma Noah Aiguobas wrote:
> Rename OnAssoc values from CamelCase to snake_case to conform to
> linux kernel coding style:
> OnAssocReq -> on_assoc_req
> OnAssocRsp -> on_assoc_rsp
> WMMOnAssocRsp -> WMM_on_assoc_rsp
> HTOnAssocRsp -> HT_on_assoc_rsp
> OnAssocReqFail -> on_assoc_req_fail
Why just these? It's a miss-mash of different things all at once.
Please make this a series that does one function at a time.
Also, when you change the function names, make them more obvious they
are in this driver as they turn into some pretty horrible global symbol
names, right?
thanks,
greg k-h