Re: [PATCH 4/5] rust_binder: consolidate transaction failure prints
From: Alice Ryhl
Date: Tue Jul 07 2026 - 09:36:51 EST
On Fri, Jun 26, 2026 at 11:28:34PM +0000, Carlos Llamas wrote:
> On Tue, Jun 23, 2026 at 03:38:07PM +0000, Alice Ryhl wrote:
> > + // We don't yet know the real message size because it depends on the secctx size, so for
> > + // now write an estimate. When the real value is computed, this estimate is replaced.
> > + // Writing an estimate here ensures that the approx message size can still be printed if
> > + // the transaction fails before it is computed exactly.
> > + info.debug_total_size = info
> > + .data_size
> > + .saturating_add(info.offsets_size)
> > + .saturating_add(info.buffers_size);
>
> hmm, I'm not so sure about this "estimation". I can see how it might be
> confusing against the "final" size, after secctx and alignment, bla bla.
> I wonder if it would be best to leave this as zero (until this is known)
> or maybe have the "raw" individual values from userspace?
I will print the raw individual values.
Alice