Re: [PATCH v2 4/6] clk: mediatek: mt8135: fix memory leak on module removal

[Brian Masney]

On Tue, Jul 07, 2026 at 04:48:33PM +0900, Akari Tsuyukusa wrote:
> clk_mt8135_apmixed_probe() in clk-mt8135-apmixedsys.c does not call
> platform_set_drvdata(), but clk_mt8135_apmixed_remove() callback calls
> platform_get_drvdata().
> This results in platform_get_drvdata() returning NULL,
> which leads to calling kfree(NULL) in mtk_free_clk_data(NULL).
> This leaves clk_data unreleased, causing a memory leak.
> 
> Fix this by calling platform_set_drvdata() during probe.
> 
> Fixes: 54b7026f011e ("clk: mediatek: mt8135-apmixedsys: Convert to platform_driver and module")
> Cc: stable@xxxxxxxxxxxxxxx
> Signed-off-by: Akari Tsuyukusa <akkun11.open@xxxxxxxxx>

Reviewed-by: Brian Masney <bmasney@xxxxxxxxxx>